fix(fqdn): allow hyphens in last domain label#1548
Merged
zemzale merged 1 commit intogo-playground:masterfrom Mar 27, 2026
Merged
fix(fqdn): allow hyphens in last domain label#1548zemzale merged 1 commit intogo-playground:masterfrom
zemzale merged 1 commit intogo-playground:masterfrom
Conversation
Contributor
Author
|
@zemzale would it be possible for you to review the MR, we have a customer who is blocked due to this issue, would be great if you could review. |
zemzale
approved these changes
Mar 27, 2026
Member
zemzale
left a comment
zemzale
left a comment
There was a problem hiding this comment.
Thanks @alihasan070707 does seem correct
Contributor
Author
|
thank you @zemzale, do you know when would these changes will make it to the release? |
bfabio
pushed a commit
to bfabio/validator
that referenced
this pull request
Apr 8, 2026
## Fixes Or Enhances ## Summary The `fqdn` validator was rejecting valid domain names that contain hyphens in the last label (e.g. `test-site-http.test-site`), because the TLD character class `[a-zA-Z0-9]` did not include `-`. ## Change One character added to the last label's character class in `fqdnRegexStringRFC1123`: No other parts of the regex were modified. ## Test Added regression case to [TestFQDNValidation](cci:1://file:///Users/admin/validator/validator_test.go:10628:0-10676:1): - `test-site-http.test-site` → valid @go-playground/validator-maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Summary
The
fqdnvalidator was rejecting valid domain names that contain hyphens in the last label (e.g.test-site-http.test-site), because the TLD character class[a-zA-Z0-9]did not include-.Change
One character added to the last label's character class in
fqdnRegexStringRFC1123:No other parts of the regex were modified.
Test
Added regression case to TestFQDNValidation:
test-site-http.test-site→ valid@go-playground/validator-maintainers